| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [DEBUG]: sk_forward_alloc assertion failures |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Fri, 14 Jan 2005 11:03:52 -0800 |
| Cc: | anton@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050114120322.GA28449@xxxxxxxxxxxxxxxxxxx> |
| References: | <20050113171234.3fde0925.davem@xxxxxxxxxxxxx> <20050114012504.GF6309@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20050113201914.46b7c4a2.davem@xxxxxxxxxxxxx> <20050114111648.GA27964@xxxxxxxxxxxxxxxxxxx> <20050114120322.GA28449@xxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 14 Jan 2005 23:03:22 +1100 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > What we need to do is to remember mss_now across sendpage calls. > Luckily the value of truesize lets us deduce the value of mss_now. > To complicate the picture the mss might have been reduced between > sendpages calls. So we take the minimum of the remembered mss > and the current mss. > > Any brave souls out there to try this? Herbert, this patch doesn't fix the bug. We still have to do the adjustments gradually just like sendmsg(). That's the whole problem. If sendmsg() creates the SKB, then sendpages() adds paged data onto the end, we don't make skb->truesize big enough. |
| Previous by Date: | Re: V2.4 policy router operates faster/better than V2.6, Jeremy M. Guthrie |
|---|---|
| Next by Date: | Re: V2.4 policy router operates faster/better than V2.6, Jeremy M. Guthrie |
| Previous by Thread: | Re: [DEBUG]: sk_forward_alloc assertion failures, Herbert Xu |
| Next by Thread: | Re: [DEBUG]: sk_forward_alloc assertion failures, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |