| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Mon, 10 Jan 2005 22:45:22 +0100 |
| Cc: | jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050110133714.023aa21b.davem@xxxxxxxxxxxxx> |
| References: | <20050109121630.GB19599@xxxxxx> <20050110133714.023aa21b.davem@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
On Mon, Jan 10, 2005 at 01:37:14PM -0800, David S. Miller wrote: > On Sun, 9 Jan 2005 13:16:30 +0100 > Christoph Hellwig <hch@xxxxxx> wrote: > > > The 8139too thread needs to use rtnl_lock_interruptible so it can avoid > > doing the actual work once it's been kill_proc()ed on module removal > > time. > > > > Based on debugging and an earlier patch that adds a driver-private > > semaphore from Herbert Xu. > > I've applied these two patches, they look perfectly fine. > Thanks Christoph. Btw, there's some confusing between rtnl_lock and rtnl_shlock (similar for the other variants). Is there an agenda behind this versions or would you take a patch that unifies the lock assecors? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang, David S. Miller |
|---|---|
| Next by Date: | [PATCH] remove unused variables in net/sunrpc/auth.c, Jesper Juhl |
| Previous by Thread: | Re: [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang, David S. Miller |
| Next by Thread: | Re: [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |