netdev
[Top] [All Lists]

[PATCH PKT_SCHED 16/22]: ipt action: fix missing unlock on error path

To: jamal <hadi@xxxxxxxxxx>
Subject: [PATCH PKT_SCHED 16/22]: ipt action: fix missing unlock on error path
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Mon, 10 Jan 2005 20:38:10 +0100
Cc: Maillist netdev <netdev@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041008 Debian/1.7.3-5

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2005/01/10 02:54:57+01:00 kaber@xxxxxxxxxxxx 
#   [PKT_SCHED]: ipt action: fix missing unlock on error path
#   
#   Simply kill the pskb_expand_head, iptables targets already take care
#   of cloned packets.
#   
#   Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
# 
# net/sched/ipt.c
#   2005/01/10 02:50:16+01:00 kaber@xxxxxxxxxxxx +0 -4
#   [PKT_SCHED]: ipt_action: fix missing unlock on error path
#   
#   Simply kill the pskb_expand_head, iptables targets already take care
#   of cloned packets.
#   
#   Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
# 
diff -Nru a/net/sched/ipt.c b/net/sched/ipt.c
--- a/net/sched/ipt.c   2005-01-10 06:22:53 +01:00
+++ b/net/sched/ipt.c   2005-01-10 06:22:53 +01:00
@@ -202,10 +202,6 @@
        p->bstats.bytes += skb->len;
        p->bstats.packets++;
 
-       if (skb_cloned(skb) ) {
-               if (pskb_expand_head(skb, 0, 0, GFP_ATOMIC))
-                       return -1;
-       }
        /* yes, we have to worry about both in and out dev
         worry later - danger - this API seems to have changed
         from earlier kernels */
<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH PKT_SCHED 16/22]: ipt action: fix missing unlock on error path, Patrick McHardy <=