Hi David
On Thu, 06 Jan 2005, David S. Miller wrote:
>
> Peter, let me know if this patch solves your PHY link up problem
> too.
>
> # This is a BitKeeper generated diff -Nru style patch.
> #
> # ChangeSet
> # 2005/01/06 14:53:55-08:00 davem@xxxxxxxxxxxxxxxxxx
> # [TG3]: Return 0 when PHY read times out, not all-ones.
> #
> # Noticed by Peter Chubb.
> #
> # Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> #
> # drivers/net/tg3.c
> # 2005/01/06 14:53:07-08:00 davem@xxxxxxxxxxxxxxxxxx +1 -1
> # [TG3]: Return 0 when PHY read times out, not all-ones.
> #
> diff -Nru a/drivers/net/tg3.c b/drivers/net/tg3.c
> --- a/drivers/net/tg3.c 2005-01-06 14:54:21 -08:00
> +++ b/drivers/net/tg3.c 2005-01-06 14:54:21 -08:00
> @@ -485,7 +485,7 @@
> udelay(80);
> }
>
> - *val = 0xffffffff;
> + *val = 0x0;
>
> frame_val = ((PHY_ADDR << MI_COM_PHY_ADDR_SHIFT) &
> MI_COM_PHY_ADDR_MASK);
No, if I revert back to an earlier driver the link comes
up OK printing:
tg3: eth0: Link is up at 1000 Mbps, full duplex.
tg3: eth0: Flow control is off for TX and off for RX.
after a short delay. With the current dirver I do not
see any prinks from tg3_link_report about the state
of the link.
Darren
--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------
|