netdev
[Top] [All Lists]

Re: TG3 fix for slow switches (Was: TG3 driver failure on HP 16-way)

To: Peter Chubb <peterc@xxxxxxxxxxxxxxxxxx>
Subject: Re: TG3 fix for slow switches (Was: TG3 driver failure on HP 16-way)
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 6 Jan 2005 15:19:10 -0800
Cc: peterc@xxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <16839.30796.413939.333935@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <16839.27239.264551.415058@xxxxxxxxxxxxxxxxxxxxxxxx> <20041220161552.2b88aa3d.davem@xxxxxxxxxxxxx> <16839.30796.413939.333935@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Peter, let me know if this patch solves your PHY link up problem
too.

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2005/01/06 14:53:55-08:00 davem@xxxxxxxxxxxxxxxxxx 
#   [TG3]: Return 0 when PHY read times out, not all-ones.
#   
#   Noticed by Peter Chubb.
#   
#   Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
# 
# drivers/net/tg3.c
#   2005/01/06 14:53:07-08:00 davem@xxxxxxxxxxxxxxxxxx +1 -1
#   [TG3]: Return 0 when PHY read times out, not all-ones.
# 
diff -Nru a/drivers/net/tg3.c b/drivers/net/tg3.c
--- a/drivers/net/tg3.c 2005-01-06 14:54:21 -08:00
+++ b/drivers/net/tg3.c 2005-01-06 14:54:21 -08:00
@@ -485,7 +485,7 @@
                udelay(80);
        }
 
-       *val = 0xffffffff;
+       *val = 0x0;
 
        frame_val  = ((PHY_ADDR << MI_COM_PHY_ADDR_SHIFT) &
                      MI_COM_PHY_ADDR_MASK);

<Prev in Thread] Current Thread [Next in Thread>