| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [RFC] tulip VLAN support |
| From: | Ben Greear <greearb@xxxxxxxxxxxxxxx> |
| Date: | Wed, 05 Jan 2005 14:17:57 -0800 |
| Cc: | Johannes Erdfelt <johannes@xxxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <41DC6669.9090407@xxxxxxxxx> |
| Organization: | Candela Technologies |
| References: | <20050105193425.GY18847@xxxxxxxxxxxx> <41DC6669.9090407@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.3) Gecko/20041020 |
Jeff Garzik wrote: Johannes Erdfelt wrote:@@ -259,7 +259,7 @@ #define RX_RING_SIZE 128 #define MEDIA_MASK 31-#define PKT_BUF_SZ 1536 /* Size of each temporary Rx buffer. */ +#define PKT_BUF_SZ 1540 /* Size of each temporary Rx buffer. */This is the reason why the tulip "vlan" patch is continually rejected. You shouldn't need to increase this constant, but rather follow the other "large MTU" driver conversions. Has anyone tried just leaving this line as it was (but adding the rest of the patch)? I believe the 1536 already has plenty of space and can hold the extra 4 bytes w/out problem. Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC] tulip VLAN support, Jeff Garzik |
|---|---|
| Next by Date: | Re: [RFC] tulip VLAN support, Johannes Erdfelt |
| Previous by Thread: | Re: [RFC] tulip VLAN support, Jeff Garzik |
| Next by Thread: | Re: [RFC] tulip VLAN support, Johannes Erdfelt |
| Indexes: | [Date] [Thread] [Top] [All Lists] |