netdev
[Top] [All Lists]

Re: [RFC] tulip VLAN support

To: Johannes Erdfelt <johannes@xxxxxxxxxxx>
Subject: Re: [RFC] tulip VLAN support
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 05 Jan 2005 17:12:57 -0500
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20050105193425.GY18847@xxxxxxxxxxxx>
References: <20050105193425.GY18847@xxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Johannes Erdfelt wrote:
@@ -259,7 +259,7 @@
#define RX_RING_SIZE 128 #define MEDIA_MASK 31 -#define PKT_BUF_SZ 1536 /* Size of each temporary Rx buffer. */
+#define PKT_BUF_SZ             1540    /* Size of each temporary Rx buffer. */


This is the reason why the tulip "vlan" patch is continually rejected. You shouldn't need to increase this constant, but rather follow the other "large MTU" driver conversions.

Donald Becker's tulip.c (on which the kernel tulip is based) supports proper MTU changing: ftp://ftp.scyld.com/pub/network/

        Jeff



<Prev in Thread] Current Thread [Next in Thread>