netdev
[Top] [All Lists]

Re: [PATCH] remove superfluous diverter printk'ing

To: Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] remove superfluous diverter printk'ing
From: jamal <hadi@xxxxxxxxxx>
Date: 16 Jan 2005 12:10:21 -0500
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050115104750.GB14991@xi.wantstofly.org>
Organization: jamalopolous
References: <20050114124700.GA4079@xi.wantstofly.org> <20050114134642.4be4e2fc.davem@davemloft.net> <20050115104750.GB14991@xi.wantstofly.org>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
Diverter could simply be killed now that tc actions exist if theres no
maintainer or user.
Should be able to divert any packet of choce to any interface.

cheers,
jamal


On Sat, 2005-01-15 at 05:47, Lennert Buytenhek wrote:
> On Fri, Jan 14, 2005 at 01:46:42PM -0800, David S. Miller wrote:
> 
> > > You're not listed as diverter maintainer but I'm sending this via
> > > you anyway.  This patch removes some printk'ing from the diverter
> > > driver (and cleans up the code a bit), because after a while it gets
> > > really annoying to have log messages like this one for every single
> > > tunnel you create or tear down.
> > > 
> > >   divert: not allocating divert_blk for non-ethernet device tunl0
> > > 
> > > Please consider sending upstream.
> > 
> > Those diverter messages drive me crazy too, I think I'll
> > add your patch Lennert.
> 
> Benoit's email address bounces, and it's the latest address of his I
> could find, so if he doesn't read this list you might as well go ahead.
> 
> 
> cheers,
> Lennert
> 
> 


<Prev in Thread] Current Thread [Next in Thread>