netdev
[Top] [All Lists]

Re: [RFC] locking changes for lec.c

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [RFC] locking changes for lec.c
From: "chas williams - CONTRACTOR" <chas@xxxxxxxxxxxxxxxx>
Date: Fri, 14 Jan 2005 21:32:51 -0500
Cc: netdev@xxxxxxxxxxx
In-reply-to: Your message of "Fri, 14 Jan 2005 13:56:12 PST." <20050114135612.0edc180d.davem@davemloft.net>
Reply-to: chas3@xxxxxxxxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
In message <20050114135612.0edc180d.davem@xxxxxxxxxxxxx>,"David S. Miller" 
writes:
>Can HW interrupt paths ever call into this ARP stuff?
>If not, probably should just use BH disabled locking
>instead of the heavy handed IRQ disabling locks.

yes, lec_push() could be run in hw interrupt context from one of of the
atm drivers recv path.  in fact, this is the path where i "noticed" the
race condition.

<Prev in Thread] Current Thread [Next in Thread>