netdev
[Top] [All Lists]

Re: [DEBUG]: sk_forward_alloc assertion failures

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [DEBUG]: sk_forward_alloc assertion failures
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 14 Jan 2005 14:04:26 -0800
Cc: anton@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050114215504.GA12569@gondor.apana.org.au>
References: <20050113171234.3fde0925.davem@davemloft.net> <20050114012504.GF6309@krispykreme.ozlabs.ibm.com> <20050113201914.46b7c4a2.davem@davemloft.net> <20050114111648.GA27964@gondor.apana.org.au> <20050114120322.GA28449@gondor.apana.org.au> <20050114110352.23c94ab9.davem@davemloft.net> <20050114203452.GA1277@gondor.apana.org.au> <20050114132757.4ca3153a.davem@davemloft.net> <20050114213829.GA12454@gondor.apana.org.au> <20050114133611.69ff0bb2.davem@davemloft.net> <20050114215504.GA12569@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 15 Jan 2005 08:55:04 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> As long as we're careful about what we've allocated in the skb then
> everything will be alright.  We're in trouble right now with mixed
> sendmsg/sendpages calls and changing MSSs only because we're not
> careful about keeping track of how much memory we've allocated
> at the start.

I see, but we don't want sendmsg() to charge a full MSS if the
user is only writing 10 bytes of data onto the wire.  That seems
to be what happens if we implement things the way you are suggesting.

<Prev in Thread] Current Thread [Next in Thread>