netdev
[Top] [All Lists]

Re: [DEBUG]: sk_forward_alloc assertion failures

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [DEBUG]: sk_forward_alloc assertion failures
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 14 Jan 2005 13:36:11 -0800
Cc: anton@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050114213829.GA12454@gondor.apana.org.au>
References: <20050113171234.3fde0925.davem@davemloft.net> <20050114012504.GF6309@krispykreme.ozlabs.ibm.com> <20050113201914.46b7c4a2.davem@davemloft.net> <20050114111648.GA27964@gondor.apana.org.au> <20050114120322.GA28449@gondor.apana.org.au> <20050114110352.23c94ab9.davem@davemloft.net> <20050114203452.GA1277@gondor.apana.org.au> <20050114132757.4ca3153a.davem@davemloft.net> <20050114213829.GA12454@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 15 Jan 2005 08:38:29 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, Jan 14, 2005 at 01:27:57PM -0800, David S. Miller wrote:
> > 
> > You missed the whole problem.
> > 
> > It has nothing to do with the MSS changing.
> 
> However if the MSS does change then it can cause the same symptoms.
> In fact the MSS can easily increase when TSO is enabled since it
> increases as the RCV window is opened up.

MSS changes are handled _transparently_ if we do the adjustments
as we actaully add data to the packet.  We always account what is
actually put into the packet in this way.

That's why I made the fix the way that I did.

<Prev in Thread] Current Thread [Next in Thread>