netdev
[Top] [All Lists]

Re: [DEBUG]: sk_forward_alloc assertion failures

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [DEBUG]: sk_forward_alloc assertion failures
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 14 Jan 2005 23:03:22 +1100
Cc: Anton Blanchard <anton@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050114111648.GA27964@gondor.apana.org.au>
References: <20050113171234.3fde0925.davem@davemloft.net> <20050114012504.GF6309@krispykreme.ozlabs.ibm.com> <20050113201914.46b7c4a2.davem@davemloft.net> <20050114111648.GA27964@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Fri, Jan 14, 2005 at 10:16:48PM +1100, herbert wrote:
> 
> Since the packet is bounded by mss_now, and most of the time it
> will be exactly mss_now bytes long, how about if we simply
> replace tp->mss_cache by mss_now?

Doh! My patch is the same as the current code :)

What we need to do is to remember mss_now across sendpage calls.  
Luckily the value of truesize lets us deduce the value of mss_now.
To complicate the picture the mss might have been reduced between
sendpages calls.  So we take the minimum of the remembered mss
and the current mss.

Any brave souls out there to try this?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>