netdev
[Top] [All Lists]

Re: [DEBUG]: sk_forward_alloc assertion failures

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [DEBUG]: sk_forward_alloc assertion failures
From: Sridhar Samudrala <sri@xxxxxxxxxx>
Date: Thu, 13 Jan 2005 17:50:17 -0800 (PST)
Cc: anton@xxxxxxxxx, netdev@xxxxxxxxxxx, herbert@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050113171234.3fde0925.davem@davemloft.net>
References: <20050113171234.3fde0925.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
Dave,

I think with this patch we will start seeing
sk_wmem_queued assertions.

Currently sk_wmem_queued seems to be accounted
correctly, but this patch changes this value too.

-Sridhar

On Thu, 13 Jan 2005, David S. Miller wrote:

>
> Anton, can you and the other IBM folks who can reproduce
> the problem give this test patch a whirl?
>
> Herbert and I aren't exactly sure what the exact sequence
> of events is that causes the problem, but we do know that
> this code is highly suspect.
>
> [ BTW, Herbert, it just occurred to me that these adjustments
>   are incorrect for the skb->data pulling case since we really
>   aren't liberating the data. ]
>
> Thanks.
>
> ===== net/ipv4/tcp_output.c 1.75 vs edited =====
> --- 1.75/net/ipv4/tcp_output.c        2004-12-28 10:22:40 -08:00
> +++ edited/net/ipv4/tcp_output.c      2005-01-13 16:45:26 -08:00
> @@ -580,12 +580,12 @@
>
>       TCP_SKB_CB(skb)->seq += len;
>       skb->ip_summed = CHECKSUM_HW;
> -
> +#if 0
>       skb->truesize        -= len;
>       sk->sk_queue_shrunk   = 1;
>       sk->sk_wmem_queued   -= len;
>       sk->sk_forward_alloc += len;
> -
> +#endif
>       /* Any change of skb->len requires recalculation of tso
>        * factor and mss.
>        */
>
>

<Prev in Thread] Current Thread [Next in Thread>