| To: | Dave Dillow <dave@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state |
| From: | Jan-Benedict Glaw <jbglaw@xxxxxxxxxx> |
| Date: | Thu, 30 Dec 2004 17:36:17 +0100 |
| Cc: | netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <1104423409.23254.9.camel@xxxxxxxxxxxxxxxxxxx> |
| Mail-followup-to: | Dave Dillow <dave@xxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| References: | <20041230035000.01@xxxxxxxxxxxxxxxxxx> <20041230035000.10@xxxxxxxxxxxxxxxxxx> <20041230094839.GX2460@xxxxxxxxxx> <1104423409.23254.9.camel@xxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Thu, 2004-12-30 11:16:49 -0500, Dave Dillow <dave@xxxxxxxxxxxxxx>
wrote in message <1104423409.23254.9.camel@xxxxxxxxxxxxxxxxxxx>:
> On Thu, 2004-12-30 at 04:48, Jan-Benedict Glaw wrote:
> > On Thu, 2004-12-30 03:48:34 -0500, David Dillow <dave@xxxxxxxxxxxxxx>
> > wrote in message <20041230035000.10@xxxxxxxxxxxxxxxxxx>:
> > > +enum {
> > > + XFRM_STATE_DIR_UNKNOWN,
> > > + XFRM_STATE_DIR_IN,
> > > + XFRM_STATE_DIR_OUT,
> > > +};
> >
> > Any specific reason to first define such a nice enum and then using int
> > in the struct?
>
> Just following the current style in net/xfrm.h, see xfrm_state.km.state
> and XFRM_STATE_*.
Hmmm... Maybe I'd prepare patches then :)
MfG, JBG
--
Jan-Benedict Glaw jbglaw@xxxxxxxxxx . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));
|
| Previous by Date: | [RESEND 2/9] PKT_SCHED: tc filter extension API, Thomas Graf |
|---|---|
| Next by Date: | Re: [PKT_SCHED]: Allow using nfmark as key in U32 classifier., Thomas Graf |
| Previous by Thread: | Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state, Dave Dillow |
| Next by Thread: | Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state, Dave Dillow |
| Indexes: | [Date] [Thread] [Top] [All Lists] |