| To: | jamal <hadi@xxxxxxxxxx> |
|---|---|
| Subject: | [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action |
| From: | Patrick McHardy <kaber@xxxxxxxxx> |
| Date: | Thu, 30 Dec 2004 04:41:51 +0100 |
| Cc: | Maillist netdev <netdev@xxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5 |
Disable broken override bits in pedit action. It misses locking and needs to allocate new memory if nkeys increases. Also disable it for now. # This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/12/30 03:56:27+01:00 kaber@xxxxxxxxxxxx
# [PKT_SCHED]: Disable broken override bits in pedit action
#
# Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
#
# net/sched/pedit.c
# 2004/12/30 03:56:20+01:00 kaber@xxxxxxxxxxxx +2 -0
# [PKT_SCHED]: Disable broken override bits in pedit action
#
# Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>
#
diff -Nru a/net/sched/pedit.c b/net/sched/pedit.c
--- a/net/sched/pedit.c 2004-12-30 04:02:10 +01:00
+++ b/net/sched/pedit.c 2004-12-30 04:02:10 +01:00
@@ -83,6 +83,8 @@
ret = -EEXIST;
if (ovr) {
+ /* FIXME: no locking, larger memory area might be required */
+ return -EOPNOTSUPP;
ret = 0;
override:
p->flags = parm->flags;
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH PKT_SCHED 16/17]: Return proper error codes in tcf_pedit_init, Patrick McHardy |
|---|---|
| Next by Date: | Re: [PATCH PKT_SCHED 0/17]: tc action cleanup + fixes, jamal |
| Previous by Thread: | [PATCH PKT_SCHED 16/17]: Return proper error codes in tcf_pedit_init, Patrick McHardy |
| Next by Thread: | Re: [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action, jamal |
| Indexes: | [Date] [Thread] [Top] [All Lists] |