Re: Patch: add loglevel to printk's in net/ipv4/route.c

[Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>]

Jesper Juhl wrote:
> Small patch below adds loglevels to a few printk's in net/ipv4/route.c
>
>
> Signed-off-by: Jesper Juhl <juhl-lkml@xxxxxx>
>
> diff -up linux-2.6.10-orig/net/ipv4/route.c linux-2.6.10/net/ipv4/route.c
> --- linux-2.6.10-orig/net/ipv4/route.c  2004-12-24 22:35:40.000000000 +0100
> +++ linux-2.6.10/net/ipv4/route.c       2004-12-29 02:55:03.000000000 +0100
> @@ -889,8 +889,8 @@ restart:
>                 printk(KERN_DEBUG "rt_cache @%02x: %u.%u.%u.%u", hash,
>                        NIPQUAD(rt->rt_dst));
>                 for (trt = rt->u.rt_next; trt; trt = trt->u.rt_next)
> -                       printk(" . %u.%u.%u.%u", NIPQUAD(trt->rt_dst));
> -               printk("\n");
> +                       printk(KERN_DEBUG " . %u.%u.%u.%u", 
> NIPQUAD(trt->rt_dst));
> +               printk(KERN_DEBUG "\n");
>         }
>  #endif
>         rt_hash_table[hash].chain = rt;
> @@ -1802,11 +1802,11 @@ martian_source:
>                         unsigned char *p = skb->mac.raw;
>                         printk(KERN_WARNING "ll header: ");
>                         for (i = 0; i < dev->hard_header_len; i++, p++) {
> -                               printk("%02x", *p);
> +                               printk(KERN_WARNING "%02x", *p);
>                                 if (i < (dev->hard_header_len - 1))
>                                         printk(":");
>                         }
> -                       printk("\n");
> +                       printk(KERN_WARNING "\n");

Are you sure the output is much improved? ;)

- Arnaldo