netdev
[Top] [All Lists]

Re: [2.6 patch] /net/ax25/: some cleanups

To: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [2.6 patch] /net/ax25/: some cleanups
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 28 Dec 2004 10:05:07 -0800
Cc: bunk@xxxxxxxxx, ralf@xxxxxxxxxxxxxx, linux-hams@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1104237408.20944.70.camel@xxxxxxxxxxxxxxxxxxxxx>
References: <20041212211339.GX22324@xxxxxxxxx> <20041227185151.2a7ceb71.davem@xxxxxxxxxxxxx> <1104237408.20944.70.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 28 Dec 2004 14:27:08 +0000
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> On Maw, 2004-12-28 at 02:51, David S. Miller wrote:
> > On Sun, 12 Dec 2004 22:13:39 +0100
> > Adrian Bunk <bunk@xxxxxxxxx> wrote:
> > 
> > > The patch below contains the following cleanups:
> > > - make two needlessly global functions static
> > > - net/ax25/ax25_addr.c: remove the unused global function ax25digicmp
> 
> Dave this function is only unused because a patch in 2.6.10 broke AX.25
> protocol support by removing the device and path checks. AX.25 is a link
> layer protocol it is supposed to check the devices and arguably the
> path. 

Send a patch to netdev and CC: me to fix this as is standard
procedure for getting changes into the networking.  :-)



<Prev in Thread] Current Thread [Next in Thread>