netdev
[Top] [All Lists]

Re: Lockup with 2.6.9-ac15 related to netconsole

To: Matt Mackall <mpm@xxxxxxxxxxx>
Subject: Re: Lockup with 2.6.9-ac15 related to netconsole
From: jamal <hadi@xxxxxxxxxx>
Date: 28 Dec 2004 08:45:20 -0500
Cc: Patrick McHardy <kaber@xxxxxxxxx>, Francois Romieu <romieu@xxxxxxxxxxxxx>, Mark Broadbent <markb@xxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041222171836.GL5974@xxxxxxxxx>
Organization: jamalopolous
References: <52121.192.102.214.6.1103624620.squirrel@xxxxxxxxxxxxxxxxxxxxxx> <20041221123727.GA13606@xxxxxxxxxxxxxxxxxxxxxxxxxx> <49295.192.102.214.6.1103635762.squirrel@xxxxxxxxxxxxxxxxxxxxxx> <20041221204853.GA20869@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20041221212737.GK5974@xxxxxxxxx> <20041221225831.GA20910@xxxxxxxxxxxxxxxxxxxxxxxxxx> <41C93FAB.9090708@xxxxxxxxx> <41C9525F.4070805@xxxxxxxxx> <20041222123940.GA4241@xxxxxxxxxxxxxxxxxxxxxxxxxx> <41C98B75.9020802@xxxxxxxxx> <20041222171836.GL5974@xxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 2004-12-22 at 12:18, Matt Mackall wrote:
> On Wed, Dec 22, 2004 at 03:57:57PM +0100, Patrick McHardy wrote:
> > >Of course the patch is completely ugly and violates any layering
> > >principle one could think of. It was not submitted for inclusion :o)
> > 
> > Sure, but I think we should have a short-term workaround until
> > a better solution has been invented. Maybe dropping the packets
> > would be best for now, it only affects printks issued in paths
> > starting at qdisc_restart (-> hard_start_xmit -> ...). Queueing
> > the packets might also cause reordering since not all packets
> > are queued.
> 
> When I mentioned queueing, I was thinking of a netpoll-private queue
> that would be hooked to a softirq or some such so that it would be
> pushed out as soon as possible. Dropping may be the better approach 

I think so - just junk those packets. 

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>