netdev
[Top] [All Lists]

Re: [2.6 patch] net/irda/: misc possible cleanups

To: Adrian Bunk <bunk@xxxxxxxxx>
Subject: Re: [2.6 patch] net/irda/: misc possible cleanups
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 27 Dec 2004 21:12:43 -0800
Cc: irda-users@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20041215010528.GA12937@xxxxxxxxx>
References: <20041215010528.GA12937@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 15 Dec 2004 02:05:28 +0100
Adrian Bunk <bunk@xxxxxxxxx> wrote:

> The patch below contains the following possible cleanups:
> - make some needlessly global code static
> - remove the following unused global functions:
>   - discovery.c: irlmp_find_device
>   - ircomm/ircomm_param.c: ircomm_param_flush
>   - irda_device.c: irda_device_set_dtr_rts
>   - irda_device.c: irda_device_change_speed
>   - irda_device.c: irda_device_set_mode
>   - iriap.c: iriap_getinfobasedetails_request
>   - iriap.c: iriap_getinfobasedetails_confirm
>   - iriap.c: iriap_getobjects_request
>   - iriap.c: iriap_getobjects_confirm
>   - iriap.c: iriap_getvalue
>   - irlan_client.c: irlan_client_reconnect_data_channel
>   - irlap_frame.c: irlap_send_frmr_frame
>   - irlmp.c: irlmp_status_request
> - remove the follwong unused global variables:
>   - irnet/irnet_ppp.c: irnet_ppp_ops
>   - irsysctl.c: sysctl_compression
> - qos.c: #ifndef CONFIG_IRDA_DYNAMIC_WINDOW irlap_requested_line_capacity

Looks good, applied.  Thanks Adrian.

<Prev in Thread] Current Thread [Next in Thread>