| To: | Eric Lemoine <eric.lemoine@xxxxxxxxx> |
|---|---|
| Subject: | Re: LLTX and netif_stop_queue |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Wed, 22 Dec 2004 20:29:19 -0800 |
| Cc: | hadi@xxxxxxxxxx, roland@xxxxxxxxxxx, netdev@xxxxxxxxxxx, openib-general@xxxxxxxxxx |
| In-reply-to: | <5cac192f04122210491d64d4b6@xxxxxxxxxxxxxx> |
| References: | <52llbwoaej.fsf@xxxxxxxxxxx> <20041217214432.07b7b21e.davem@xxxxxxxxxxxxx> <1103484675.1050.158.camel@xxxxxxxxxxxxxxxx> <5cac192f04122210491d64d4b6@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 22 Dec 2004 19:49:48 +0100 Eric Lemoine <eric.lemoine@xxxxxxxxx> wrote: > Instead, I would suggest to have LLTX drivers check whether queue is > stopped after they grab their private tx lock and before they check tx > ring fullness. That way we close the race window but keep the driver > bug check around. > > See attached sungem patch. That sounds about right. Nice idea. It solves the race, and retains the error state check. I'll apply Eric's patch, and do something similar in the other LLTX drivers (except loopback which has not "queue" per se so doesn't need this stuff). |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: TG3 fix for slow switches (Was: TG3 driver failure on HP 16-way), Michael Chan |
|---|---|
| Next by Date: | Re: TG3 fix for slow switches (Was: TG3 driver failure on HP 16-way), David S. Miller |
| Previous by Thread: | Re: LLTX and netif_stop_queue, Eric Lemoine |
| Next by Thread: | Re: LLTX and netif_stop_queue, Roland Dreier |
| Indexes: | [Date] [Thread] [Top] [All Lists] |