netdev
[Top] [All Lists]

Re: [patch 4/10] s390: network driver.

To: Thomas Spatzier <thomas.spatzier@xxxxxxxxxx>
Subject: Re: [patch 4/10] s390: network driver.
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 22 Dec 2004 06:07:52 -0500
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, hadi@xxxxxxxxxx, Hasso Tepper <hasso@xxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Paul Jakma <paul@xxxxxxxx>, Tommy Christensen <tommy.christensen@xxxxxxxxx>
In-reply-to: <OFD729E7DA.203E1D4A-ONC1256F72.003B7A8E-C1256F72.003C1150@xxxxxxxxxx>
References: <41C71FFD.7090308@xxxxxxxxx> <OFD729E7DA.203E1D4A-ONC1256F72.003B7A8E-C1256F72.003C1150@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Wed, Dec 22, 2004 at 11:56:06AM +0100, Thomas Spatzier wrote:
> on cable reconnected:
>       netif_carrier_on();
>       netif_wake_queue();

Side note to all driver authors, make sure you only ever start or
wake the queue if there is truly space available for another skb.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>