netdev
[Top] [All Lists]

Re: [PATCH] PKT_SCHED: Provide compat policer stats in action policer

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] PKT_SCHED: Provide compat policer stats in action policer
From: jamal <hadi@xxxxxxxxxx>
Date: 20 Dec 2004 09:32:44 -0500
Cc: Patrick McHardy <kaber@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041220140325.GW17998@xxxxxxxxxxxxxx>
Organization: jamalopolous
References: <20041215130128.GK8493@xxxxxxxxxxxxxx> <1103119774.1077.74.camel@xxxxxxxxxxxxxxxx> <41C05B60.6030504@xxxxxxxxx> <1103484249.1046.143.camel@xxxxxxxxxxxxxxxx> <41C6A6CC.1050105@xxxxxxxxx> <20041220140325.GW17998@xxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2004-12-20 at 09:03, Thomas Graf wrote:

> 
> Ifs and buts, it was solely and purely my fault. period.
> 

No fault on anyone - its a process of improving what we do.

> Agreed, the only bug which would have been easly found with the
> testframework was the CBQ slab corruption bug due deleting
> filters twice added with your generic filter deletion simplification.
> Unfortunately, I'm more error-prone than most so I need a testframework.

I need it to ;-> It will help me be less conservative ;->
Thomas, we need automation of these tests - I just relaized what you
have is not really in that category. Refer to sample example i posted.
Doesnt have to be exactly like that, but somewhere along those lines.

cheers,
jamal



<Prev in Thread] Current Thread [Next in Thread>