Re: [PATCH] PKT_SCHED: dsmark must take care of shared/cloned skbs

[jamal <hadi@xxxxxxxxxx>]

On Mon, 2004-12-20 at 03:06, Patrick McHardy wrote:

> You shouldn't care about IMQ, but we still need to copy the packet
> before modifying it if the data is shared. Otherwise we have a race
> on SMP with AF_PACKET sockets, depending on when the packet is read
> it can be either modified or not.

Certainly not a big deal; shouldnt care if once in a while tcpdump
actually gets to see the real packet that went out the wire.

> Converting dsmark to an action sounds like the best long-term solution.

Indeed; hence my comment to talk to Werner.

cheers,
jamal