netdev
[Top] [All Lists]

Re: [PATCH] PKT_SCHED: Provide compat policer stats in action policer

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH] PKT_SCHED: Provide compat policer stats in action policer
From: Thomas Graf <tgraf@xxxxxxx>
Date: Mon, 20 Dec 2004 15:03:25 +0100
Cc: hadi@xxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <41C6A6CC.1050105@xxxxxxxxx>
References: <20041215130128.GK8493@xxxxxxxxxxxxxx> <1103119774.1077.74.camel@xxxxxxxxxxxxxxxx> <41C05B60.6030504@xxxxxxxxx> <1103484249.1046.143.camel@xxxxxxxxxxxxxxxx> <41C6A6CC.1050105@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* Patrick McHardy <41C6A6CC.1050105@xxxxxxxxx> 2004-12-20 11:17
> I agree that this problem would have been avoided if the
> regression tests were run when the change was made, and it
> made sense to run them at that time. Unfortunately I missed
> the patch when it went in, otherwise I would have objected
> to using a field called "priv" and making assumptions about
> the layout of the structure it points to in a file called
> act_api anyway.

Ifs and buts, it was solely and purely my fault. period.

> On a side-note, you both seem to be inventing your own testing
> framework and regression tests. tcng already includes lots of
> regression tests for tc, tcng and the kernel. Unfortunately,
> last time I checked, it didn't work with 2.6.

The tests are based on tcsim which might behave differently than
the kernel itself. My test framework primarly tries to cover
iproute - kernel incompatbilities and tries to trigger bugs
by running every bit of code in every possible combination.

> I don't feel like I'm distributing burden onto anyone. As I
> said, I run the tests I deem necessary, and I never send out
> patches of whichs correctness I'm not convinced. So far, my
> history of mistakes has been pretty good.

Agreed, the only bug which would have been easly found with the
testframework was the CBQ slab corruption bug due deleting
filters twice added with your generic filter deletion simplification.
Unfortunately, I'm more error-prone than most so I need a testframework.

<Prev in Thread] Current Thread [Next in Thread>