netdev
[Top] [All Lists]

Re: [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver

To: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver
From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Mon, 20 Dec 2004 13:14:35 +0100
Cc: roland@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, openib-general@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041220.155836.75677852.yoshfuji@xxxxxxxxxxxxxx>
References: <200412192215.69tnzAhGIT1vQGLF@xxxxxxxxxxx> <200412192215.fZX1ZQqQD4QGkKcF@xxxxxxxxxxx> <20041220.155836.75677852.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.6.2
On Maandag 20 Dezember 2004 07:58, YOSHIFUJI Hideaki / 吉藤英明 wrote:
> Roland Dreier <roland@xxxxxxxxxxx> says:
> 
> > +enum {
> > +     IPOIB_PACKET_SIZE         = 2048,
> > +     IPOIB_BUF_SIZE            = IPOIB_PACKET_SIZE + IB_GRH_BYTES,
> > +
> > +     IPOIB_ENCAP_LEN           = 4,
> > +
> > +     IPOIB_RX_RING_SIZE        = 128,
> > +     IPOIB_TX_RING_SIZE        = 64,
> > +
> 
> above entries does not seem to appropriate for enum (than #define).

According to Documentation/CodingStyle, it actually is preferred like this.
See also include/linux/ide.h for another example where this is done.

 Arnd <><


<Prev in Thread] Current Thread [Next in Thread>