netdev
[Top] [All Lists]

Re: [PATCH] PKT_SCHED: dsmark must take care of shared/cloned skbs

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH] PKT_SCHED: dsmark must take care of shared/cloned skbs
From: Thomas Graf <tgraf@xxxxxxx>
Date: Sat, 18 Dec 2004 22:00:54 +0100
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20041218170017.GH17998@xxxxxxxxxxxxxx>
References: <20041218170017.GH17998@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
> Correctly handle shared and cloned skbs by copying them before writing
> and dequeue unwriteable skbs unchanged. Assumes that IP/IPv6 header
> is always linear so no pulling required.

Hmm.. OTOH, setting skb->tc_index in enqueue() might need a pskb_copy() in
some cases. I'm not aware of such a path though, does anyone know about
a path where it would be required?  If so it would be better to make the
skb writeable in enqueue() to safe a copy.

<Prev in Thread] Current Thread [Next in Thread>