Re: [PATCH 2/5] sis900 printk and stack usage audit

[Daniele Venzano <webvenza@xxxxxxxxx>]

On Sat, Dec 11, 2004 at 02:09:10PM -0500, Jeff Garzik wrote:
> >@@ -568,14 +580,15 @@
> > 
> >             for (i = 0; mii_chip_table[i].phy_id1; i++)
> >                     if ((mii_phy->phy_id0 == mii_chip_table[i].phy_id0 ) 
> >                     &&
> >-                        ((mii_phy->phy_id1 & 0xFFF0) == 
> >mii_chip_table[i].phy_id1)){
> >+                        ((mii_phy->phy_id1 & 0xFFF0) == 
> >mii_chip_table[i].phy_id1))
> >+                    {
> 
> CodingStyle:  the brace following an 'if' does not exist on a line by 
> itself.

The line is too long, and it is difficult to see where the if block
begins, I know it is an exception to the Golden Rules, but I thought a
line wasted in code readbility was well wasted.
However I don't think it really matters, will drop it.

-- 
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org