netdev
[Top] [All Lists]

Re: [PATCH 2/5] sis900 printk and stack usage audit

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH 2/5] sis900 printk and stack usage audit
From: Daniele Venzano <webvenza@xxxxxxxxx>
Date: Sun, 12 Dec 2004 09:19:04 +0100
Cc: Daniele Venzano <webvenza@xxxxxxxxx>, NetDev <netdev@xxxxxxxxxxx>
In-reply-to: <41BB45D6.2090608@xxxxxxxxx>
Mail-followup-to: Jeff Garzik <jgarzik@xxxxxxxxx>, Daniele Venzano <webvenza@xxxxxxxxx>, NetDev <netdev@xxxxxxxxxxx>
References: <20041208104721.GA31707@xxxxxxxxxxxxxxx> <20041208110426.GC31707@xxxxxxxxxxxxxxx> <41BB45D6.2090608@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, Dec 11, 2004 at 02:09:10PM -0500, Jeff Garzik wrote:
> >@@ -568,14 +580,15 @@
> > 
> >             for (i = 0; mii_chip_table[i].phy_id1; i++)
> >                     if ((mii_phy->phy_id0 == mii_chip_table[i].phy_id0 ) 
> >                     &&
> >-                        ((mii_phy->phy_id1 & 0xFFF0) == 
> >mii_chip_table[i].phy_id1)){
> >+                        ((mii_phy->phy_id1 & 0xFFF0) == 
> >mii_chip_table[i].phy_id1))
> >+                    {
> 
> CodingStyle:  the brace following an 'if' does not exist on a line by 
> itself.

The line is too long, and it is difficult to see where the if block
begins, I know it is an exception to the Golden Rules, but I thought a
line wasted in code readbility was well wasted.
However I don't think it really matters, will drop it.

-- 
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org


<Prev in Thread] Current Thread [Next in Thread>