netdev
[Top] [All Lists]

Re: [PATCH 1/5] sis900 printk and stack usage audit

To: Daniele Venzano <webvenza@xxxxxxxxx>
Subject: Re: [PATCH 1/5] sis900 printk and stack usage audit
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sat, 11 Dec 2004 14:06:21 -0500
Cc: NetDev <netdev@xxxxxxxxxxx>
In-reply-to: <20041208110156.GB31707@xxxxxxxxxxxxxxx>
References: <20041208104721.GA31707@xxxxxxxxxxxxxxx> <20041208110156.GB31707@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Daniele Venzano wrote:
Removed double printing of version string in module_init and in sis900_probe

@@ -390,13 +390,6 @@
        u8 revision;
        char *card_name = card_names[pci_id->driver_data];
-/* when built into the kernel, we only print version if device is found */
-#ifndef MODULE
-       static int printed_version;
-       if (!printed_version++)
-               printk(version);
-#endif
-
        /* setup various bits in PCI command register */
        ret = pci_enable_device(pci_dev);
        if(ret) return ret;

There is no double-printing.  One is #ifndef MODULE, one is #ifdef MODULE.

Did you read the comment included in the code you deleted???

        Jeff



<Prev in Thread] Current Thread [Next in Thread>