netdev
[Top] [All Lists]

Re: [PATCH] fix select() for SOCK_RAW sockets

To: Mitchell Blank Jr <mitch@xxxxxxxxxx>
Subject: Re: [PATCH] fix select() for SOCK_RAW sockets
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Tue, 7 Dec 2004 09:45:35 -0800
Cc: Phil Oester <kernel@xxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-net@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041207150834.GA75700@xxxxxxxxxxxxxx>
Organization: Open Source Development Lab
References: <20041207003525.GA22933@xxxxxxxxxxxx> <20041207025218.GB61527@xxxxxxxxxxxxxx> <20041207045302.GA23746@xxxxxxxxxxxx> <20041207054840.GD61527@xxxxxxxxxxxxxx> <20041207150834.GA75700@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 7 Dec 2004 07:08:34 -0800
Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote:

> Phil: Here's a real patch for you to test.  I actually left inet_dgram_ops
> alone since it's an exported symbol (two of the users just want the .do_ioctl
> value which is the same between SOCK_DGRAM and SOCK_RAW; the other is ipv6
> where it's clearly dealing with a UDP socket -- therefore I think its safest
> to leave inet_dgram_ops to have the UDP behavior)
> 
> Davem: I only tested that this doesn't break UDP; if it works for Phil and
> Stephen can verify that it doesn't break his bad-checksum UDP tests then
> please push it for 2.6.10.
> 

Thanks, I'll retest UDP today, but it looks right.

<Prev in Thread] Current Thread [Next in Thread>