netdev
[Top] [All Lists]

Re: [PATCH] rtnetlink & address family problem

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] rtnetlink & address family problem
From: jamal <hadi@xxxxxxxxxx>
Date: 06 Dec 2004 21:27:41 -0500
Cc: Michal Ludvig <mludvig@xxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx, Jan Kara <jack@xxxxxxx>
In-reply-to: <20041206140214.GA749@xxxxxxxxxxxxxx>
Organization: jamalopolous
References: <41B0A5B4.6060108@xxxxxxx> <20041206140214.GA749@xxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2004-12-06 at 09:02, Thomas Graf wrote:

> Your patch would fix this issue but might break various things. The
> actual problem is that iproute2 doesn't check the family in its filter.
> It blindly assumes that the kernel only returns addresses of the kind it
> has requested. I can understand if you think the current behaviour
> is wrong but we shouldn't change it in the middle of a stable tree.

Why would it be wrong? The PF_UNSPEC is there for a purpose.

If user space decides it wants to flush ipv4 addresses blindly that user
spaces fault. The patch you attached seems legit. did you verify it?

BTW, Stephen - are you still updating iproute2? 

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>