netdev
[Top] [All Lists]

Re: [PATCH] rtnetlink & address family problem

To: Michal Ludvig <mludvig@xxxxxxx>
Subject: Re: [PATCH] rtnetlink & address family problem
From: jamal <hadi@xxxxxxxxxx>
Date: 06 Dec 2004 06:40:43 -0500
Cc: Andrew Morton <akpm@xxxxxxxx>, netdev@xxxxxxxxxxx, Jan Kara <jack@xxxxxxx>
In-reply-to: <41B0A5B4.6060108@xxxxxxx>
Organization: jamalopolous
References: <41B0A5B4.6060108@xxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
I think this patch will break more than it fixes. You need to do a lot
more testing to verify it doesnt. Actually you should probably fix whats
being invoked for the ifa messages when PF_UNSPEC is selected to check
that it only flushes v6 addresses when V6 is on and reject when it is
not compiled in.

cheers,
jamal

On Fri, 2004-12-03 at 12:43, Michal Ludvig wrote:
> Hi,
> 
> running 'ip -6 addr flush dev eth0' on a kernel without IPv6 support
> flushes *all* addresses from the interface, even those IPv4 ones,
> because the unsupported protocol is substituted by PF_UNSPEC.
> IMHO it should better return with an error EAFNOSUPPORT.
> 
> Attached patch fixes it. Please apply.
> 
> BTW Credits to Jan Kara <jack@xxxxxxx> for discovering and analysing
> this bug.
> 
> Michal Ludvig


<Prev in Thread] Current Thread [Next in Thread>