netdev
[Top] [All Lists]

Re: [PATCH] Deadlock in af_packet/packet_rcv

To: Tommy Christensen <tommy.christensen@xxxxxxxxx>
Subject: Re: [PATCH] Deadlock in af_packet/packet_rcv
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 30 Nov 2004 13:07:11 -0800
Cc: okir@xxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <41AC5FEE.8020707@xxxxxxxxx>
References: <20041125205503.GA18083@xxxxxxx> <41AC3E2F.2030003@xxxxxxxxx> <20041130110110.GD16970@xxxxxxx> <41AC5A26.6000400@xxxxxxxxx> <20041130114535.GF16970@xxxxxxx> <41AC5FEE.8020707@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 30 Nov 2004 12:56:30 +0100
Tommy Christensen <tommy.christensen@xxxxxxxxx> wrote:

> > i.e. there's no local_bh_disable at all - adding the local_bh_disable
> > was the whole point of my patch. Or did you refer to a different spinlock?
> 
> The local_bh_disable() is called earlier in dev_queue_xmit(), and
> is held across the whole HARD_TX_LOCK/dev_queue_xmit_nit/
> hard_start_xmit/HARD_TX_UNLOCK sequence.

He's right.  There must be something else happening in your
tree Olaf.

<Prev in Thread] Current Thread [Next in Thread>