netdev
[Top] [All Lists]

Re: [PATCH] fix missing security_*() check in net/compat.c

To: Mitchell Blank Jr <mitch@xxxxxxxxxx>
Subject: Re: [PATCH] fix missing security_*() check in net/compat.c
From: James Morris <jmorris@xxxxxxxxxx>
Date: Tue, 30 Nov 2004 11:17:41 -0500 (EST)
Cc: netdev@xxxxxxxxxxx, Chris Wright <chrisw@xxxxxxxx>, Stephen Smalley <sds@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <20041130145444.GF63669@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 30 Nov 2004, Mitchell Blank Jr wrote:

> While looking at the SCM passing code in net/core/scm.c I noticed that there's
> a 32-bit compat implementation of scm_detach_fds()'s called 
> scm_detach_fds_compat() living in net/compat.c.  While these two functions
> are mostly the same the latter does not include the call to the
> security_file_receive() hook which is almost certainly a bug.
> 
> My sparc64 test box isn't set up currently so this is not tested.  Someone
> running a 64-bit kernel with CONFIG_COMPAT should verify that this at
> least compiles.
> 
> Signed-off-by: Mitchell Blank Jr <mitch@xxxxxxxxxx>

Looks correct to me.

Signed-off-by: James Morris <jmorris@xxxxxxxxxx>



-- 
James Morris
<jmorris@xxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>