netdev
[Top] [All Lists]

[PATCH] b44: allow ethtool get_settings when down

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH] b44: allow ethtool get_settings when down
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Mon, 29 Nov 2004 09:45:23 -0800
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
Organization: Open Source Development Lab
Sender: netdev-bounce@xxxxxxxxxxx
The FC and Suse startup scripts use ethtool to check for link present. This has 
problems on my laptop with Broadcom because it quieries settings before
bringing link up. The problem is driver returns EAGAIN when queried for
settings but not up. Just go ahead and return values anyway, the supported and 
link
state values will be correct, speed will end up being 10BaseT/Half which is a
reasonable default.

Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>

diff -Nru a/drivers/net/b44.c b/drivers/net/b44.c
--- a/drivers/net/b44.c 2004-11-29 09:41:27 -08:00
+++ b/drivers/net/b44.c 2004-11-29 09:41:27 -08:00
@@ -1487,8 +1487,6 @@
 {
        struct b44 *bp = netdev_priv(dev);
 
-       if (!(bp->flags & B44_FLAG_INIT_COMPLETE))
-               return -EAGAIN;
        cmd->supported = (SUPPORTED_Autoneg);
        cmd->supported |= (SUPPORTED_100baseT_Half |
                          SUPPORTED_100baseT_Full |

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] b44: allow ethtool get_settings when down, Stephen Hemminger <=