| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [patch 10/13] net/socket.c::sys_bind() cleanup. |
| From: | Luiz Fernando Capitulino <lcapitulino@xxxxxxxxxxxxxxxx> |
| Date: | Wed, 24 Nov 2004 08:55:10 -0200 |
| Cc: | akpm@xxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20041124002709.52cb8d1f.davem@xxxxxxxxxxxxx> |
| Organization: | Conectiva S/A |
| References: | <200411220644.iAM6i8900672@xxxxxxxxxxxxx> <20041124002709.52cb8d1f.davem@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla Thunderbird 0.7.3 (X11/20040803) |
David S. Miller wrote: On Sun, 21 Nov 2004 22:43:56 -0800 akpm@xxxxxxxx wrote:From: "Luiz Fernando N. Capitulino" <lcapitulino@xxxxxxxxxxxxxxxx> net/socket.c::sys_bind() is a bit complex function, the patch below makes it more clear. Signed-off-by: Luiz Capitulino <lcapitulino@xxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>This was commented on to be buggy, or at least change behavior. The "if (err >= 0)" tests were changed to flat "if (err)" tests. It doesn't a buggy or change behaivor. What happens here is that move_addr_to_kernel() returns 0 success and -EINVAL or -EFAULT on error. Thus, change from "if (err >= 0)" to "if (err)" is safe. Also, it was discussed and ACK'ed by James Morris: http://lkml.org/lkml/2004/11/16/339 The real problem here I've made a bad patch description. I'll try to make it better next time. thanks, -- Luiz Fernando N. Capitulino |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Add ssleep_interruptible(), Horms |
|---|---|
| Next by Date: | [e1000] print bus type/speed/width on probe, Lennert Buytenhek |
| Previous by Thread: | Re: [patch 10/13] net/socket.c::sys_bind() cleanup., David S. Miller |
| Next by Thread: | Re: [patch 10/13] net/socket.c::sys_bind() cleanup., David Stevens |
| Indexes: | [Date] [Thread] [Top] [All Lists] |