netdev
[Top] [All Lists]

Re: Fix ipv6_ifa_notify race

To: herbert@xxxxxxxxxxxxxxxxxxx
Subject: Re: Fix ipv6_ifa_notify race
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Fri, 19 Nov 2004 11:36:58 -0500 (EST)
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, acme@xxxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <20041119094924.GA3726@xxxxxxxxxxxxxxxxxxx>
Organization: USAGI Project
References: <4197AC20.6020707@xxxxxxxxx> <E1CTR5h-0006ac-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041119094924.GA3726@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <20041119094924.GA3726@xxxxxxxxxxxxxxxxxxx> (at Fri, 19 Nov 2004 
20:49:24 +1100), Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> says:

> On Mon, Nov 15, 2004 at 07:35:17AM +1100, Herbert Xu wrote:
> > 
> > Could you please apply this patch and see if the warning triggers
> > before the underflows start coming in? We already know that if it
> > does then it can cause underflows but I want to make sure that
> > this is what's causing your problems.
> 
> Well I think it's time to fix this bug so that we don't release
> 2.6.10 with it.
> 
> This is only a temporary hack that should be rolled back once
> the locking in addrconf.c is fixed properly.  At the moment
> the locking is just too twisted to fix properly for 2.6.10 :(

This patch is wrong (dead is not protected appropriately).
I have another idea to fix this.
I'll send it tomorrow.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>