netdev
[Top] [All Lists]

Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using

To: Chris Wright <chrisw@xxxxxxxx>
Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET
From: James Morris <jmorris@xxxxxxxxxx>
Date: Fri, 19 Nov 2004 02:12:58 -0500 (EST)
Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>, Ross Kendall Axe <ross.axe@xxxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, Stephen Smalley <sds@xxxxxxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <20041118230109.V2357@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 18 Nov 2004, Chris Wright wrote:

> > (Also now ignores any supplied address per 
> > http://www.opengroup.org/onlinepubs/009695399/functions/sendto.html)
> 
> Nitpick, but I missed where it said ignore the address.  And it seems
> counter intuitive to provide address, only to have it ignored and
> delivered elsewhere.

For sendto():
  "If the socket is connection-mode, dest_addr shall be ignored."

For sendmsg():
  "If the socket is connection-mode, the destination address in msghdr 
   shall be ignored."

I agree that it's counter intuitive (and surely an application bug), but
some feedback I've had suggests we follow the spec.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>