| To: | linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
|---|---|
| Subject: | [patch netdev-2.6] vlan_dev: return 0 on vlan_dev_change_mtu success |
| From: | "John W. Linville" <linville@xxxxxxxxxxxxx> |
| Date: | Thu, 18 Nov 2004 14:04:36 -0500 |
| Cc: | greearb@xxxxxxxxxxxxxxx, vlan@xxxxxxxxxxxxxxxx |
| Mail-followup-to: | linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, greearb@xxxxxxxxxxxxxxx, vlan@xxxxxxxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5.1i |
The VLAN net driver needs to return 0 from vlan_dev_change_mtu()
on success.
Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
---
The proper sucessful return code for the change_mtu() method is zero.
For some reason, vlan_dev_change_mtu() is returning the new mtu value
instead.
net/8021q/vlan_dev.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- 1.23/net/8021q/vlan_dev.c 2004-10-28 19:23:09 -04:00
+++ 1.24/net/8021q/vlan_dev.c 2004-11-18 11:12:36 -05:00
@@ -527,7 +527,7 @@
dev->mtu = new_mtu;
- return new_mtu;
+ return 0;
}
int vlan_dev_set_ingress_priority(char *dev_name, __u32 skb_prio, short
vlan_prio)
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Wrong UIDs reported in /proc/net/tcp, Chad N. Tindel |
|---|---|
| Next by Date: | [patch netdev-2.6] skge: return 0 on success from SkGeChangeMtu, John W. Linville |
| Previous by Thread: | [PATCH][6/12][RFC/v1] Add IPoIB (IP-over-InfiniBand) driver, Roland Dreier |
| Next by Thread: | Re: [patch netdev-2.6] vlan_dev: return 0 on vlan_dev_change_mtu success, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |