netdev
[Top] [All Lists]

Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using

To: Chris Wright <chrisw@xxxxxxxx>
Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET
From: James Morris <jmorris@xxxxxxxxxx>
Date: Thu, 18 Nov 2004 12:11:18 -0500 (EST)
Cc: Ross Kendall Axe <ross.axe@xxxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, Stephen Smalley <sds@xxxxxxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <20041118090706.O2357@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 18 Nov 2004, Chris Wright wrote:

> Right, but the snippet I posted guards against that I think.  It forces
> unix_peer_get() in dgram_sendmsg.

Correct.  We could also add more code to dgram_sendmsg() to simply ignore
any address passed in for SOCK_SEQPACKETs, but again, I think that is a
programming error and I think we should signal that, especially as this is
a new feature.



- James
-- 
James Morris
<jmorris@xxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>