netdev
[Top] [All Lists]

Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using

To: Chris Wright <chrisw@xxxxxxxx>
Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET
From: James Morris <jmorris@xxxxxxxxxx>
Date: Thu, 18 Nov 2004 12:01:34 -0500 (EST)
Cc: Ross Kendall Axe <ross.axe@xxxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, Stephen Smalley <sds@xxxxxxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <20041118084449.Z14339@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 18 Nov 2004, Chris Wright wrote:

> Why not make a unix_seq_sendmsg, which is a very small wrapper?

Good idea, patch forthcoming.

> Does the above stop the other issue?  My laptop died, so I'm not able to
> test ATM.

No, it seems to be caused when addrlen in sendto() is non-zero, causing 
unix_find_other() to be called instead of unix_peer_get(), which is 
screwing up reference counts.

As for MSG_EOR, apart from the generic socket code, nothing is being done.  
This would be a separate issue.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>