Re: Assertions when lowering tcp_tso_win_divisor

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

David S. Miller <davem@xxxxxxxxxxxxx> wrote:
>
>> KERNEL: assertion (!sk->sk_forward_alloc) failed at net/core/stream.c (279)
>> KERNEL: assertion (!sk->sk_forward_alloc) failed at net/ipv4/af_inet.c (152)
>> 
>> looks like an issue with the accounting of sk_forward_alloc with non-default
>> values of tcp_tso_win_divisor.
> 
> The issue is if you change the value while there are still existing
> sockets which used a previous value at least once.

Could you elaborate the code path that you've spotted that causes this
when the divisor is changed?

Perhaps we're not caching the MSS value everywhere where we should be?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt