| To: | Stephen Hemminger <shemminger@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] (4/25) sk98: change #define to typedef |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 16 Nov 2004 08:22:54 +0000 |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, Mirko Lindner <demon@xxxxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20041115152203.24adb0ea@xxxxxxxxxxxxxxxxx> |
| References: | <20041115150910.0f3b8498@xxxxxxxxxxxxxxxxx> <20041115152203.24adb0ea@xxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Mon, Nov 15, 2004 at 03:22:03PM -0800, Stephen Hemminger wrote: > Change #define of to a typedef. > > Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx> > > diff -Nru a/drivers/net/sk98lin/h/skdrv1st.h > b/drivers/net/sk98lin/h/skdrv1st.h > --- a/drivers/net/sk98lin/h/skdrv1st.h 2004-11-15 11:22:28 -08:00 > +++ b/drivers/net/sk98lin/h/skdrv1st.h 2004-11-15 11:22:28 -08:00 > @@ -106,7 +106,7 @@ > #define SK_MAX_MACS 2 > #define SK_MAX_NETS 2 > > -#define SK_IOC char __iomem * > +typedef void __iomem *SK_IOC; Why do you need the typedef at all? Just about every driver on the planet is fine with a single void *__iomem iobase; in the per-device structure |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | VME IP Driver Development - some questions, Hendrik Wiese |
|---|---|
| Next by Date: | Re: [PATCH] (5/25) sk98: elimnate nested macro., Christoph Hellwig |
| Previous by Thread: | [PATCH] (4/25) sk98: change #define to typedef, Stephen Hemminger |
| Next by Thread: | Re: [PATCH] (4/25) sk98: change #define to typedef, Mirko Lindner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |