| To: | "Christoph Hellwig" <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] (15/23) sk98: rearrange initialization |
| From: | shemminger@xxxxxxxx |
| Date: | Fri, 12 Nov 2004 20:43:47 -0800 (PST) |
| Cc: | "Stephen Hemminger" <shemminger@xxxxxxxx>, "Jeff Garzik" <jgarzik@xxxxxxxxx>, "Michael Heyse" <mhk@xxxxxxxxxxxxxxxxx>, "Mirko Lindner" <mlindner@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx |
| Importance: | Normal |
| In-reply-to: | <20041112163041.GC7066@xxxxxxxxxxxxx> |
| References: | <4192C60A.1050205@xxxxxxxxxxxxxxxxx> <20041111154225.5cf85567@xxxxxxxxxxxxxxxxx> <20041111160113.15a356cd@xxxxxxxxxxxxxxxxx> <20041112163041.GC7066@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | SquirrelMail/1.4.2-1_osdl_00 |
> On Thu, Nov 11, 2004 at 04:01:13PM -0800, Stephen Hemminger wrote: >> The code in the latest SysKonnect driver is arranged differently, >> this aligns the two versions to allow for easier comparisons. >> Also: >> Don't enable the pci device twice. >> Add common SkGeDevInit for common code used to setup both ports > > please don't reorder the functions. I placed them in natural order when > converting to new pci probing for a good reason. I really don't care which way it goes, just trying to make SysKonnect's life easeier. When all the comments are in, I will redo the patches without the reordering |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] (7/23) sk98: basic ethtool support, shemminger |
|---|---|
| Next by Date: | Re: A case AGAINST checksum offload, Francois Romieu |
| Previous by Thread: | Re: [PATCH] (15/23) sk98: rearrange initialization, Christoph Hellwig |
| Next by Thread: | [PATCH] (14/23) sk98: don't obfuscate irqreturn_t, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |