netdev
[Top] [All Lists]

Re: [PATCH] [TRY2] Use nfmark as a key in u32 classifier

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] [TRY2] Use nfmark as a key in u32 classifier
From: "Catalin(ux aka Dino) BOIE" <util@xxxxxxxxxxxxxxx>
Date: Tue, 9 Nov 2004 15:46:21 +0200 (EET)
Cc: davem@xxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, lartc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041109133035.GH31969@xxxxxxxxxxxxxx>
References: <Pine.LNX.4.61.0411091406570.20094@xxxxxxxxxxxxxxxxxxx> <20041109133035.GH31969@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* Catalin(ux aka Dino) BOIE 
<Pine.LNX.4.61.0411091406570.20094@xxxxxxxxxxxxxxxxxxx> 2004-11-09 14:27
This is the try number two.
What was changed:
- Added selectable choice in Kconfig file (thanks Jamal!)
- Don't abuse tc_u32_sel to not break backward compatibility (thanks
Patrick!).

Your patchs looks fine except for missing dependcy on CONFIG_NETFILTER.
Either make CLS_U32_MARK dependant on it or #ifdef the references
to skb->nfmark.

Patch updated and attached.

It might be fair to tell you that this code is likely to be removed
again once we have the metadata match.

Jamal already warned me about this.
Is somebody already working on it?

Cheers

Thank you!
---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/

Attachment: net-match-nfmark-in-u32-try3.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>