netdev
[Top] [All Lists]

Re: [PATCH 2.6] ixgb: fix ixgb_intr looping checks

To: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
Subject: Re: [PATCH 2.6] ixgb: fix ixgb_intr looping checks
From: Andrew Morton <akpm@xxxxxxxx>
Date: Mon, 8 Nov 2004 15:10:48 -0800
Cc: jgarzik@xxxxxxxxx, jesse.brandeburg@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0411081446550.18540-100000@xxxxxxxxxxxxxxxxxxxx>
References: <418B2C3F.60107@xxxxxxxxx> <Pine.LNX.4.44.0411081446550.18540-100000@xxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> wrote:
>
> This patch undoes a change that we believe will impact performance adversely,
> by creating possibly too long a delay between servicing completions.

Maybe.  But now take a look at how much additional pointless work will be
done in the common case.  For instance, every tx completion will incur a
call to ixgb_clean_rx_irq(), which then calls ixgb_alloc_rx_buffers().

There's quite a bit which can be optimised here.

<Prev in Thread] Current Thread [Next in Thread>