| To: | Patrick McHardy <kaber@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] PKT_SCHED: Initialize list field in dummy qdiscs |
| From: | Thomas Graf <tgraf@xxxxxxx> |
| Date: | Sun, 7 Nov 2004 20:08:41 +0100 |
| Cc: | davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, spam@xxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx |
| In-reply-to: | <418E67D0.8010301@xxxxxxxxx> |
| References: | <418C2D40.9020300@xxxxxxxxx> <20041106015931.GA28715@xxxxxxxxxxxxxx> <20041106145036.GB28715@xxxxxxxxxxxxxx> <418DE37E.2050504@xxxxxxxxx> <20041107140015.GA31969@xxxxxxxxxxxxxx> <418E4B2E.1070407@xxxxxxxxx> <20041107163330.GB31969@xxxxxxxxxxxxxx> <418E553C.2070006@xxxxxxxxx> <20041107174909.GC31969@xxxxxxxxxxxxxx> <418E67D0.8010301@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
> >Anyways, I do think we should force the task to be completed, or > >at least all the list unlinking, before the rtnl semaphore is given > >back. I'm fine with postponing the deletion of the object but not > >to postpone list manipulations even if we cannot reproduce it now. > > This is what I'm doing now, your patch to set qdisc->parent makes > this very easy :) Simply remove all qdiscs with > (TC_H_MAJ(q->parent) == TC_H_MAJ(qdisc->handle)) from > dev->qdisc_list when a classful qdisc is destroyed. Great, that's even better, speeds up deletion of big class trees. Thanks. |
| Previous by Date: | Re: [PATCH] PKT_SCHED: Initialize list field in dummy qdiscs, Patrick McHardy |
|---|---|
| Next by Date: | Re: PROBLEM: IProute hangs after running traffic shaping scripts, Patrick McHardy |
| Previous by Thread: | Re: [PATCH] PKT_SCHED: Initialize list field in dummy qdiscs, Patrick McHardy |
| Next by Thread: | Re: [PATCH] PKT_SCHED: Initialize list field in dummy qdiscs, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |