Re: [IPV6] Fix dst leak in ipv6_add_addr

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Sat, Nov 06, 2004 at 12:05:18AM -0800, David S. Miller wrote:
> On Sat, 6 Nov 2004 15:41:21 +1100
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Found another error-path dst leak.  If the idev->dead check is
> > triggered in ipv6_add_addr the rt entry will leak.
> 
> This one was fixed in the xfrm_lookup() patch I sent yesterday :-)

Indeed, I overlooked that message :)

However your version still leaks the rt since its refcnt is set to 1.
It will also dereference an unitialised rt if allocating ifa fails.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt