netdev
[Top] [All Lists]

Re: [PATCH 2.6 PKT_SCHED]: Fix rcu_assign_pointer fallout, use it in the

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH 2.6 PKT_SCHED]: Fix rcu_assign_pointer fallout, use it in the right place
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 5 Nov 2004 16:46:55 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <418BF48A.5060707@xxxxxxxxx>
References: <418BF48A.5060707@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 05 Nov 2004 22:45:46 +0100
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> The patch "RCU: use rcu_assign_pointer()" 
> http://linux.bkbits.net:8080/linux-2.6/diffs/net/sched/sch_api.c@xxxx?nav=index.html|src/net/|src/net|src/net/sched|related/net/sched/sch_api.c|cset@xxxxxx
> changed a list_add_tail to list_add_tail_rcu in qdisc_create. It's
> dev->qdisc not dev->qdisc_list that is protected by RCU, this patch
> reverts that change. It also removes a misleading comment and replaces
> the smp_wmb in qdisc_create_dflt by rcu_assign_pointer in dev_activate
> to document more clearly what is protected.

Good catch Patrick, patch applied.

Thanks a lot.

<Prev in Thread] Current Thread [Next in Thread>