Re: [PATCH 2/3] r8169: Large Send enablement

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Jon Mason <jdmason@xxxxxxxxxx> :
> On Tuesday 02 November 2004 01:11 pm, Francois Romieu wrote:
> [...]
> > - If rtl8169_open() fails [*] when the device was previously up, the driver
> >   could/should try to recover.
> 
> I disagree.  It should fail, complain loudly, and let the user try and fix it 
> (or return it to the previous state).  The code provided below will act like 

Mmmm... Actually both patches try to paper over the real issue: the driver
should reserve the ressources it needs for the change of mtu first.
Ok, I'll take the patch provided I can't find anything badly racy in it and
focus on the 8139C+/8169 merge. It has already been delayed for too long
and it seems the right place to fix the aforementionned issue with style :o)

--
Ueimor