| To: | Patrick McHardy <kaber@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6]: Fix device leaks in mirred action |
| From: | jamal <hadi@xxxxxxxxxx> |
| Date: | 04 Nov 2004 10:23:53 -0500 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <418A439F.2010401@xxxxxxxxx> |
| Organization: | jamalopolous |
| References: | <4189CC6A.9040007@xxxxxxxxx> <1099576439.1038.147.camel@xxxxxxxxxxxxxxxx> <418A439F.2010401@xxxxxxxxx> |
| Reply-to: | hadi@xxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Thu, 2004-11-04 at 09:58, Patrick McHardy wrote: > jamal wrote: > > >>It also leaks a reference when a mirred action > >>is replaced. > > > >How? Is this patch supposed to fix that? > > > > > + if (ovr) > + dev_put(p->dev); > p->dev = dev; > > By dropping the reference before replacing it. > Ok, makes sense. Thanks Patrick. Dave please apply the patch in its entirety. cheers, jamal |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2.6]: Fix device leaks in mirred action, Patrick McHardy |
|---|---|
| Next by Date: | Re: [PATCH 2.6 5/5]: act_api: mark some functions static/remove unused function, Patrick McHardy |
| Previous by Thread: | Re: [PATCH 2.6]: Fix device leaks in mirred action, Patrick McHardy |
| Next by Thread: | kernel scalability, Anil Gunturu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |